[
https://issues.apache.org/jira/browse/CB-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480380#comment-16480380
]
ASF GitHub Bot commented on CB-11691:
-------------------------------------
stevengill commented on a change in pull request #20: CB-11691: Fix for
modifying binary plists
URL: https://github.com/apache/cordova-common/pull/20#discussion_r189204842
##########
File path: spec/fixtures/plugins/org.apache.bplist/plugin.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0";
+ xmlns:android="http://schemas.android.com/apk/res/android";
+ id="org.apache.bplist"
+ version="3.0.0">
+
+ <name>Binary PList updates</name>
+
+ <!-- ios -->
+ <platform name="ios">
+ <config-file target="*-binary.plist" parent="CFBundleIcons">
+ <dict>
Review comment:
*nit: should code under `config-file` be intended
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Plugin <config-file> can't modify binary plists
> -----------------------------------------------
>
> Key: CB-11691
> URL: https://issues.apache.org/jira/browse/CB-11691
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
> Environment: Mac OS X version: 10.11.6
> Node version: v0.12.7
> Cordova version: 6.3.0
> Reporter: Sky Kelsey
> Priority: Major
>
> https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/plist-helpers.js#L27
> Cordova expects plists to be in XML format, and not binary. However, it fails
> to apply changes silently, masking the problem. Can you please log failures
> to modify config files, and ideally also add support for binary plists? All
> plists are generated as binary in xcode projects by default, so anyone who
> develops a plugin and needs to modify a plist is going to hit this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
