[
https://issues.apache.org/jira/browse/CB-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480898#comment-16480898
]
ASF GitHub Bot commented on CB-13770:
-------------------------------------
dpogue closed pull request #18: CB-13770: Warn when <edit-config> or
<config-file> not found
URL: https://github.com/apache/cordova-common/pull/18
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ConfigChanges/ConfigChanges.js
b/src/ConfigChanges/ConfigChanges.js
index 1780d25..e7ad0e2 100644
--- a/src/ConfigChanges/ConfigChanges.js
+++ b/src/ConfigChanges/ConfigChanges.js
@@ -79,6 +79,8 @@ function PlatformMunger_apply_file_munge (file, munge,
remove) {
if (config_file.exists) {
if (remove) config_file.prune_child(selector,
munge.parents[selector][xml_child]);
else config_file.graft_child(selector,
munge.parents[selector][xml_child]);
+ } else {
+ events.emit('warn', 'config file ' + file + ' requested for
changes not found at ' + config_file.filepath + ', ignoring');
}
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Warn when target file of <config-file> or <edit-config> is not found
> --------------------------------------------------------------------
>
> Key: CB-13770
> URL: https://issues.apache.org/jira/browse/CB-13770
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
> Reporter: Jacques Caron
> Assignee: Darryl Pogue
> Priority: Minor
> Labels: pull-request-available
>
> When one uses <config-file> or <edit-config> in config.xml or plugin.xml,
> files that are not found are silently ignored.
> Adding a warning, and including where the file is actually looked for helps
> when debugging such config elements.
> PR upcoming.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
