[
https://issues.apache.org/jira/browse/CB-14064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480909#comment-16480909
]
ASF GitHub Bot commented on CB-14064:
-------------------------------------
dpogue closed pull request #15: CB-14064: Dependency updates & drop node4 CI
URL: https://github.com/apache/cordova-common/pull/15
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..91582f4
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,22 @@
+<!--
+Please make sure the checklist boxes are all checked before submitting the PR.
The checklist
+is intended as a quick reference, for complete details please see our
Contributor Guidelines:
+
+http://cordova.apache.org/contribute/contribute_guidelines.html
+
+Thanks!
+-->
+
+### Platforms affected
+
+
+### What does this PR do?
+
+
+### What testing has been done on this change?
+
+
+### Checklist
+- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in
the JIRA database
+- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
+- [ ] Added automated test coverage as appropriate for this change.
diff --git a/.travis.yml b/.travis.yml
index 4592c3e..25b631d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,9 +3,9 @@ sudo: false
git:
depth: 10
node_js:
- - "4"
- "6"
- "8"
+ - "10"
install:
- npm install
- npm install -g codecov
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..f34dfbd 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,10 +3,10 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
-
+ - nodejs_version: "10"
+
install:
- ps: Install-Product node $env:nodejs_version
- npm install
diff --git a/package.json b/package.json
index 7e0b096..609e8ff 100644
--- a/package.json
+++ b/package.json
@@ -14,7 +14,7 @@
},
"main": "cordova-common.js",
"engines": {
- "node": ">=4.0.0"
+ "node": ">=6.0.0"
},
"scripts": {
"test": "npm run eslint && npm run jasmine",
@@ -26,29 +26,27 @@
"ansi": "^0.3.1",
"bplist-parser": "^0.1.0",
"cordova-registry-mapper": "^1.1.8",
- "elementtree": "0.1.6",
- "glob": "^5.0.13",
+ "elementtree": "0.1.7",
+ "glob": "^7.1.2",
"minimatch": "^3.0.0",
- "osenv": "^0.1.3",
- "plist": "^1.2.0",
+ "plist": "^3.0.1",
"q": "^1.4.1",
- "semver": "^5.0.1",
- "shelljs": "^0.5.3",
- "underscore": "^1.8.3",
- "unorm": "^1.3.3"
+ "shelljs": "^0.8.1",
+ "underscore": "^1.8.3"
},
"devDependencies": {
"eslint": "^4.0.0",
- "eslint-config-semistandard": "^11.0.0",
- "eslint-config-standard": "^10.2.1",
+ "eslint-config-semistandard": "^12.0.1",
+ "eslint-config-standard": "^11.0.0",
"eslint-plugin-import": "^2.3.0",
- "eslint-plugin-node": "^5.0.0",
+ "eslint-plugin-node": "^6.0.1",
"eslint-plugin-promise": "^3.5.0",
"eslint-plugin-standard": "^3.0.1",
"istanbul": "^0.4.5",
- "jasmine": "^2.5.2",
+ "jasmine": "^3.1.0",
+ "osenv": "^0.1.3",
"promise-matchers": "^0.9.6",
- "rewire": "^2.5.1"
+ "rewire": "^4.0.1"
},
"contributors": []
}
diff --git a/src/superspawn.js b/src/superspawn.js
index 424934e..8051184 100644
--- a/src/superspawn.js
+++ b/src/superspawn.js
@@ -35,7 +35,7 @@ function resolveWindowsExe (cmd) {
if (isValidExe(cmd)) {
return cmd;
}
- cmd = shell.which(cmd) || cmd;
+ cmd = String(shell.which(cmd) || cmd);
if (!isValidExe(cmd)) {
winExtensions.some(function (ext) {
if (fs.existsSync(cmd + ext)) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove Node 4 from CI - cordova-common
> --------------------------------------
>
> Key: CB-14064
> URL: https://issues.apache.org/jira/browse/CB-14064
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-common
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Minor
> Labels: CI, pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
