[
https://issues.apache.org/jira/browse/CB-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482210#comment-16482210
]
ASF GitHub Bot commented on CB-14102:
-------------------------------------
knight9999 opened a new pull request #614: CB-14102: Fix tests use specified
npm version
URL: https://github.com/apache/cordova-lib/pull/614
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
This is only test codes in order to pass the travis ci.
### What does this PR do?
1. Test ios platform version is changed to [email protected] instead of [email protected].
[email protected] is too old for the latest cordova-cli and brings installing error.
2. Use npm 5.7.1 instead of 5.6.x.
Because [email protected] has an issue.
The issue is on npm’s Github: https://github.com/npm/npm/issues/17379
As a result, `cordova plugin add` with github url brings error in test.
### What testing has been done on this change?
Using [email protected] instead of [email protected]
Using [email protected] instead of default npm.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> "cordova plugin add" removes other plugins installed from Github
> -----------------------------------------------------------------
>
> Key: CB-14102
> URL: https://issues.apache.org/jira/browse/CB-14102
> Project: Apache Cordova
> Issue Type: Wish
> Components: cordova-fetch
> Affects Versions: 8.0.0
> Reporter: Ken Naito
> Priority: Minor
> Fix For: 8.0.0
>
>
> The cordova platform/plugin add commands use cordova-fetch to get the
> relevant files. It does this by using npm.
> However, [email protected] has an issue when installing modules from Github.
> npm modules installed from a Github URL will be removed after installing
> other npm modules.
> The issue is on npm’s Github: https://github.com/npm/npm/issues/17379
> For example, using node v9.5.0, npm v5.6.0 and cordova 8.0, run
> $ cordova plugin add https://github.com/knight9999/HelloWorldPlugin.git
> This adds helloworldplugin into the node_modules directory, as shown below:
> $ ls node_modules/
> fs-extra helloworldplugin jsonfile universalify
> graceful-fs install npm
> If we add further plugins like so:
> $ cordova plugin add cordova-plugin-camera
> The previous modules in node_modules directory disappear.
> $ ls node_modules/
> cordova-plugin-camera
> This is fixed in [email protected], as mentioned in the issue link above.
> It is possible that the user cannot update their global npm version due to
> some other dependencies. I suggest that we add a way for the user to override
> the npm executable which is used by Cordova. For example, we could add an
> environment variable as below, which would be used instead of the global npm:
> CORDOVA_NPM=/home/user/bin/npm
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
