[
https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482344#comment-16482344
]
ASF GitHub Bot commented on CB-14098:
-------------------------------------
shazron closed pull request #21: CB-14098: Remove unused res folder
URL: https://github.com/apache/cordova-app-hello-world/pull/21
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/template_src/res/README.md b/template_src/res/README.md
deleted file mode 100644
index bffb33b..0000000
--- a/template_src/res/README.md
+++ /dev/null
@@ -1,29 +0,0 @@
-<!--
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
--->
-
-Note that these image resources are not copied into a project when a project
-is created with the CLI. Although there are default image resources in a
-newly-created project, those come from the platform-specific project template,
-which can generally be found in the platform's `template` directory. Until
-icon and splashscreen support is added to the CLI, these image resources
-aren't used directly.
-
-See https://issues.apache.org/jira/browse/CB-5145
diff --git a/template_src/res/icon/android/icon-36-ldpi.png
b/template_src/res/icon/android/icon-36-ldpi.png
deleted file mode 100644
index cd5032a..0000000
Binary files a/template_src/res/icon/android/icon-36-ldpi.png and /dev/null
differ
diff --git a/template_src/res/icon/android/icon-48-mdpi.png
b/template_src/res/icon/android/icon-48-mdpi.png
deleted file mode 100644
index e79c606..0000000
Binary files a/template_src/res/icon/android/icon-48-mdpi.png and /dev/null
differ
diff --git a/template_src/res/icon/android/icon-72-hdpi.png
b/template_src/res/icon/android/icon-72-hdpi.png
deleted file mode 100644
index 4d27634..0000000
Binary files a/template_src/res/icon/android/icon-72-hdpi.png and /dev/null
differ
diff --git a/template_src/res/icon/android/icon-96-xhdpi.png
b/template_src/res/icon/android/icon-96-xhdpi.png
deleted file mode 100644
index ec7ffbf..0000000
Binary files a/template_src/res/icon/android/icon-96-xhdpi.png and /dev/null
differ
diff --git a/template_src/res/icon/bada-wac/icon-48-type5.png
b/template_src/res/icon/bada-wac/icon-48-type5.png
deleted file mode 100644
index 8ad8bac..0000000
Binary files a/template_src/res/icon/bada-wac/icon-48-type5.png and /dev/null
differ
diff --git a/template_src/res/icon/bada-wac/icon-50-type3.png
b/template_src/res/icon/bada-wac/icon-50-type3.png
deleted file mode 100644
index c6ddf84..0000000
Binary files a/template_src/res/icon/bada-wac/icon-50-type3.png and /dev/null
differ
diff --git a/template_src/res/icon/bada-wac/icon-80-type4.png
b/template_src/res/icon/bada-wac/icon-80-type4.png
deleted file mode 100644
index f86a27a..0000000
Binary files a/template_src/res/icon/bada-wac/icon-80-type4.png and /dev/null
differ
diff --git a/template_src/res/icon/bada/icon-128.png
b/template_src/res/icon/bada/icon-128.png
deleted file mode 100644
index 3516df3..0000000
Binary files a/template_src/res/icon/bada/icon-128.png and /dev/null differ
diff --git a/template_src/res/icon/blackberry/icon-80.png
b/template_src/res/icon/blackberry/icon-80.png
deleted file mode 100644
index f86a27a..0000000
Binary files a/template_src/res/icon/blackberry/icon-80.png and /dev/null differ
diff --git a/template_src/res/icon/blackberry10/icon-80.png
b/template_src/res/icon/blackberry10/icon-80.png
deleted file mode 100644
index f86a27a..0000000
Binary files a/template_src/res/icon/blackberry10/icon-80.png and /dev/null
differ
diff --git a/template_src/res/icon/ios/icon-57-2x.png
b/template_src/res/icon/ios/icon-57-2x.png
deleted file mode 100644
index efd9c37..0000000
Binary files a/template_src/res/icon/ios/icon-57-2x.png and /dev/null differ
diff --git a/template_src/res/icon/ios/icon-57.png
b/template_src/res/icon/ios/icon-57.png
deleted file mode 100644
index c795fc4..0000000
Binary files a/template_src/res/icon/ios/icon-57.png and /dev/null differ
diff --git a/template_src/res/icon/ios/icon-72-2x.png
b/template_src/res/icon/ios/icon-72-2x.png
deleted file mode 100644
index dd819da..0000000
Binary files a/template_src/res/icon/ios/icon-72-2x.png and /dev/null differ
diff --git a/template_src/res/icon/ios/icon-72.png
b/template_src/res/icon/ios/icon-72.png
deleted file mode 100644
index b1cfde7..0000000
Binary files a/template_src/res/icon/ios/icon-72.png and /dev/null differ
diff --git a/template_src/res/icon/tizen/icon-128.png
b/template_src/res/icon/tizen/icon-128.png
deleted file mode 100644
index 3516df3..0000000
Binary files a/template_src/res/icon/tizen/icon-128.png and /dev/null differ
diff --git a/template_src/res/icon/webos/icon-64.png
b/template_src/res/icon/webos/icon-64.png
deleted file mode 100644
index 03b3849..0000000
Binary files a/template_src/res/icon/webos/icon-64.png and /dev/null differ
diff --git a/template_src/res/icon/windows-phone/icon-173-tile.png
b/template_src/res/icon/windows-phone/icon-173-tile.png
deleted file mode 100644
index 4f15e20..0000000
Binary files a/template_src/res/icon/windows-phone/icon-173-tile.png and
/dev/null differ
diff --git a/template_src/res/icon/windows-phone/icon-48.png
b/template_src/res/icon/windows-phone/icon-48.png
deleted file mode 100644
index 8ad8bac..0000000
Binary files a/template_src/res/icon/windows-phone/icon-48.png and /dev/null
differ
diff --git a/template_src/res/icon/windows-phone/icon-62-tile.png
b/template_src/res/icon/windows-phone/icon-62-tile.png
deleted file mode 100644
index aab6061..0000000
Binary files a/template_src/res/icon/windows-phone/icon-62-tile.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-hdpi-landscape.png
b/template_src/res/screen/android/screen-hdpi-landscape.png
deleted file mode 100644
index a61e2b1..0000000
Binary files a/template_src/res/screen/android/screen-hdpi-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-hdpi-portrait.png
b/template_src/res/screen/android/screen-hdpi-portrait.png
deleted file mode 100644
index 5d6a28a..0000000
Binary files a/template_src/res/screen/android/screen-hdpi-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-ldpi-landscape.png
b/template_src/res/screen/android/screen-ldpi-landscape.png
deleted file mode 100644
index f3934cd..0000000
Binary files a/template_src/res/screen/android/screen-ldpi-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-ldpi-portrait.png
b/template_src/res/screen/android/screen-ldpi-portrait.png
deleted file mode 100644
index 65ad163..0000000
Binary files a/template_src/res/screen/android/screen-ldpi-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-mdpi-landscape.png
b/template_src/res/screen/android/screen-mdpi-landscape.png
deleted file mode 100644
index a1b697c..0000000
Binary files a/template_src/res/screen/android/screen-mdpi-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-mdpi-portrait.png
b/template_src/res/screen/android/screen-mdpi-portrait.png
deleted file mode 100644
index ea15693..0000000
Binary files a/template_src/res/screen/android/screen-mdpi-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-xhdpi-landscape.png
b/template_src/res/screen/android/screen-xhdpi-landscape.png
deleted file mode 100644
index 79f2f09..0000000
Binary files a/template_src/res/screen/android/screen-xhdpi-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/android/screen-xhdpi-portrait.png
b/template_src/res/screen/android/screen-xhdpi-portrait.png
deleted file mode 100644
index c2e8042..0000000
Binary files a/template_src/res/screen/android/screen-xhdpi-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/bada-wac/screen-type3.png
b/template_src/res/screen/bada-wac/screen-type3.png
deleted file mode 100755
index ea15693..0000000
Binary files a/template_src/res/screen/bada-wac/screen-type3.png and /dev/null
differ
diff --git a/template_src/res/screen/bada-wac/screen-type4.png
b/template_src/res/screen/bada-wac/screen-type4.png
deleted file mode 100755
index 5d6a28a..0000000
Binary files a/template_src/res/screen/bada-wac/screen-type4.png and /dev/null
differ
diff --git a/template_src/res/screen/bada-wac/screen-type5.png
b/template_src/res/screen/bada-wac/screen-type5.png
deleted file mode 100755
index bd64f76..0000000
Binary files a/template_src/res/screen/bada-wac/screen-type5.png and /dev/null
differ
diff --git a/template_src/res/screen/bada/screen-portrait.png
b/template_src/res/screen/bada/screen-portrait.png
deleted file mode 100644
index 5d6a28a..0000000
Binary files a/template_src/res/screen/bada/screen-portrait.png and /dev/null
differ
diff --git a/template_src/res/screen/blackberry/screen-225.png
b/template_src/res/screen/blackberry/screen-225.png
deleted file mode 100644
index 29873e9..0000000
Binary files a/template_src/res/screen/blackberry/screen-225.png and /dev/null
differ
diff --git a/template_src/res/screen/blackberry10/splash-1280x768.png
b/template_src/res/screen/blackberry10/splash-1280x768.png
deleted file mode 100644
index 5f4bca9..0000000
Binary files a/template_src/res/screen/blackberry10/splash-1280x768.png and
/dev/null differ
diff --git a/template_src/res/screen/blackberry10/splash-720x720.png
b/template_src/res/screen/blackberry10/splash-720x720.png
deleted file mode 100644
index fe1756f..0000000
Binary files a/template_src/res/screen/blackberry10/splash-720x720.png and
/dev/null differ
diff --git a/template_src/res/screen/blackberry10/splash-768x1280.png
b/template_src/res/screen/blackberry10/splash-768x1280.png
deleted file mode 100644
index 0fb9c1b..0000000
Binary files a/template_src/res/screen/blackberry10/splash-768x1280.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-ipad-landscape-2x.png
b/template_src/res/screen/ios/screen-ipad-landscape-2x.png
deleted file mode 100644
index 0b50ed7..0000000
Binary files a/template_src/res/screen/ios/screen-ipad-landscape-2x.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-ipad-landscape.png
b/template_src/res/screen/ios/screen-ipad-landscape.png
deleted file mode 100644
index b2f6019..0000000
Binary files a/template_src/res/screen/ios/screen-ipad-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-ipad-portrait-2x.png
b/template_src/res/screen/ios/screen-ipad-portrait-2x.png
deleted file mode 100644
index cdac6a7..0000000
Binary files a/template_src/res/screen/ios/screen-ipad-portrait-2x.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-ipad-portrait.png
b/template_src/res/screen/ios/screen-ipad-portrait.png
deleted file mode 100644
index 7f1792c..0000000
Binary files a/template_src/res/screen/ios/screen-ipad-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-iphone-landscape-2x.png
b/template_src/res/screen/ios/screen-iphone-landscape-2x.png
deleted file mode 100644
index 0165669..0000000
Binary files a/template_src/res/screen/ios/screen-iphone-landscape-2x.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-iphone-landscape.png
b/template_src/res/screen/ios/screen-iphone-landscape.png
deleted file mode 100644
index d154883..0000000
Binary files a/template_src/res/screen/ios/screen-iphone-landscape.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-iphone-portrait-2x.png
b/template_src/res/screen/ios/screen-iphone-portrait-2x.png
deleted file mode 100644
index bd24886..0000000
Binary files a/template_src/res/screen/ios/screen-iphone-portrait-2x.png and
/dev/null differ
diff --git a/template_src/res/screen/ios/screen-iphone-portrait-568h-2x.png
b/template_src/res/screen/ios/screen-iphone-portrait-568h-2x.png
deleted file mode 100644
index 10ed683..0000000
Binary files a/template_src/res/screen/ios/screen-iphone-portrait-568h-2x.png
and /dev/null differ
diff --git a/template_src/res/screen/ios/screen-iphone-portrait.png
b/template_src/res/screen/ios/screen-iphone-portrait.png
deleted file mode 100644
index 6fcba56..0000000
Binary files a/template_src/res/screen/ios/screen-iphone-portrait.png and
/dev/null differ
diff --git a/template_src/res/screen/tizen/README.md
b/template_src/res/screen/tizen/README.md
deleted file mode 100644
index 82c3f21..0000000
--- a/template_src/res/screen/tizen/README.md
+++ /dev/null
@@ -1,24 +0,0 @@
-<!--
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
--->
-
-# Tizen Splash Screen
-
-Splash screens are unsupported on the Tizen platform.
diff --git a/template_src/res/screen/webos/screen-64.png
b/template_src/res/screen/webos/screen-64.png
deleted file mode 100644
index 03b3849..0000000
Binary files a/template_src/res/screen/webos/screen-64.png and /dev/null differ
diff --git a/template_src/res/screen/windows-phone/screen-portrait.jpg
b/template_src/res/screen/windows-phone/screen-portrait.jpg
deleted file mode 100644
index 479d3e4..0000000
Binary files a/template_src/res/screen/windows-phone/screen-portrait.jpg and
/dev/null differ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unused res folder from app template
> ------------------------------------------
>
> Key: CB-14098
> URL: https://issues.apache.org/jira/browse/CB-14098
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world
> Affects Versions: 3.11.0
> Reporter: Raphael
> Priority: Major
>
> The res folder weighs around 10MiB and contains resources for a whole lot of
> platforms, most of which are actually deprecated. Furthermore, as I
> understand the included `README.md` (which I'm not sure I do), the contents
> of this folder seem to not even being used for anything.
> So my proposal is to remove this directory from the template. That would
> decrease the installation size of `cordova` by about two thirds and remove
> unnecessary clutter from any newly created apps.
> If I did get anything wrong and this is actually used, we should probably
> clarify the README, remove all content related to deprecated platforms (like
> suggested in CB-13726) and run them through some compressors (pngquant and
> zopflipng).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
