[ 
https://issues.apache.org/jira/browse/CB-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483220#comment-16483220
 ] 

ASF GitHub Bot commented on CB-14096:
-------------------------------------

Menardi opened a new pull request #821: CB-14096: Fix platforms image 
overflowing on mobile
URL: https://github.com/apache/cordova-docs/pull/821
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
   is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Website
   
   ### What does this PR do?
   As part of https://github.com/apache/cordova-docs/pull/818, I removed 
deprecated platforms from the image under supported platforms on the landing 
page. However, as a result, the image does not resize correctly on mobile. This 
PR sets a `max-width` to resize it correctly.
   
   Before:
   
![before](https://user-images.githubusercontent.com/2932890/40335281-cf40a01a-5d9d-11e8-9cba-9faed785372f.png)
   
   After:
   ![screen shot 2018-05-22 at 8 42 
24](https://user-images.githubusercontent.com/2932890/40335293-da68acda-5d9d-11e8-88fc-c0d21231ea8d.png)
   
   ### What testing has been done on this change?
   Manual testing on Chrome on Android
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Landing page still shows deprecated platforms
> ---------------------------------------------
>
>                 Key: CB-14096
>                 URL: https://issues.apache.org/jira/browse/CB-14096
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-docs
>            Reporter: GearĂ³id M
>            Priority: Minor
>
> The [landing page|http://cordova.apache.org/] still shows icons for 
> deprecated platforms such as Blackberry and Firefox OS. These should be 
> removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to