[
https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483565#comment-16483565
]
ASF GitHub Bot commented on CB-12940:
-------------------------------------
cthos commented on issue #335: CB-12940: [IOS] Use deployment-target from
config.xml for platform version in Podfile
URL: https://github.com/apache/cordova-ios/pull/335#issuecomment-390883070
@shazron - That doesn't cover the case where they just do a `cordova plugin
add`, right?
It'd have to go something like this (I could totally be missing something
key here though):
1. `cordova plugin add foo-plugin`
2. Said plugin fails to install due to the Podfile having the wrong version
3. `cordova platform rm ios`
4. `cordova platform add ios` <--- Hook fires after this is done?
Or are we saying the implementing project would have to implement such a
hook _before_ they add the plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use deployment-target for platform version in Podfile
> -----------------------------------------------------
>
> Key: CB-12940
> URL: https://issues.apache.org/jira/browse/CB-12940
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Affects Versions: cordova-ios@4.4.0
> Reporter: Todd Miller
> Assignee: Shazron Abdullah
> Priority: Major
> Labels: backlog
> Fix For: cordova-ios@4.5.5
>
>
> The current Podfile.js script is hardcoded to set the platform ios version to
> 8.0. However, there are some pods that require 9.0 or they will fail to
> install. The deployment-target preference should be honored and used when
> generating the Podfile.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
