[
https://issues.apache.org/jira/browse/CB-13999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486714#comment-16486714
]
ASF GitHub Bot commented on CB-13999:
-------------------------------------
shazron closed pull request #52: CB-13999: (browser) - Reading config.xml
respects base href
URL: https://github.com/apache/cordova-browser/pull/52
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cordova-js-src/confighelper.js b/cordova-js-src/confighelper.js
index 4d99959..34d8b19 100644
--- a/cordova-js-src/confighelper.js
+++ b/cordova-js-src/confighelper.js
@@ -66,7 +66,7 @@ function readConfig(success, error) {
try {
- xhr.open("get", "/config.xml", true);
+ xhr.open("get", "config.xml", true);
xhr.send();
} catch(e) {
fail('[Browser][cordova.js][readConfig] Could not XHR config.xml: ' +
JSON.stringify(e));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Reading config.xml on browser platform does not respect base href
> -----------------------------------------------------------------
>
> Key: CB-13999
> URL: https://issues.apache.org/jira/browse/CB-13999
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
> Affects Versions: [email protected]
> Reporter: Geoff Tripoli
> Assignee: Jesse MacFadyen
> Priority: Minor
> Labels: config.xml
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If you use a custom base href in your index html, the preceding "/" in the
> xhr that gets the config.xml will cause the base to be ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
