[
https://issues.apache.org/jira/browse/CB-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499591#comment-16499591
]
ASF GitHub Bot commented on CB-14101:
-------------------------------------
codecov-io commented on issue #446: CB-14101 Fix Java version check for Java >=
9
URL: https://github.com/apache/cordova-android/pull/446#issuecomment-394129217
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=h1)
Report
> Merging
[#446](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/02ee92510376b23476039e29e1ec5ffaf2102b83?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 44.16% 44.21% +0.04%
==========================================
Files 17 17
Lines 1698 1694 -4
Branches 314 312 -2
==========================================
- Hits 750 749 -1
+ Misses 948 945 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/446/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz)
| `48.57% <0%> (+0.44%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=footer).
Last update
[02ee925...22d10bb](https://codecov.io/gh/apache/cordova-android/pull/446?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check_reqs.js does not recognize java version
> ---------------------------------------------
>
> Key: CB-14101
> URL: https://issues.apache.org/jira/browse/CB-14101
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 8.0.0
> Environment: OS = Arch Linux
> JAVA = javac 9.0.4
> CORDOVA = 8.0.0
> Reporter: Arne Simon
> Assignee: Raphael
> Priority: Major
>
> The java version i am using produces following output.
> {code}
> > javac -version
> javac 9.0.4
> {code}
>
> The error happens in two points:
> {code:java}
> // We use tryCommand with catchStderr = true, because
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true).then(function (output) {
> // Let's check for at least Java 8, and keep it future proof so we can
> support Java 10
> var match = /javac
> ((?:1\.)(?:[8-9]\.)(?:\d+))|((?:1\.)(?:[1-9]\d+\.)(?:\d+))/i.exec(output);
> return match && match[1];
> });{code}
> 1. _platforms/android/cordova/lib/check_reqs.js:218_
> The comment states that javac prints to stderr, this is not true on my system
> it prints to stdout!
> 2. _platforms/android/cordova/lib/check_reqs.js:220_
> The regex only looks after version numbers like 1.8 or 1.9 or 10, but the
> version number my java version prints is _9.0.4_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
