[
https://issues.apache.org/jira/browse/CB-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504728#comment-16504728
]
ASF GitHub Bot commented on CB-14066:
-------------------------------------
dpogue closed pull request #21: CB-14066: Drop support for Node 4
URL: https://github.com/apache/cordova-fetch/pull/21
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 53f19a8..f50997f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,9 +3,9 @@ sudo: false
git:
depth: 10
node_js:
- - "4"
- "6"
- "8"
+ - "10"
install:
- "npm install"
script:
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..eb430ca 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,10 +3,10 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
-
+ - nodejs_version: "10"
+
install:
- ps: Install-Product node $env:nodejs_version
- npm install
@@ -16,4 +16,7 @@ build: off
test_script:
- node --version
- npm --version
+ # Solution proposed in
https://stackoverflow.com/questions/49256190/how-to-fix-git-sh-setup-file-not-found-in-windows#comment88245403_49256190
+ # to work around https://github.com/appveyor/ci/issues/2420
+ - set "PATH=%PATH%;C:\Program Files\Git\mingw64\libexec\git-core"
- npm test
diff --git a/package.json b/package.json
index 305030c..04ede01 100644
--- a/package.json
+++ b/package.json
@@ -45,7 +45,7 @@
"jasmine": "jasmine spec/fetch.spec.js spec/fetch-unit.spec.js"
},
"engines": {
- "node": ">=4.0.0",
- "npm": ">= 2.5.1"
+ "node": ">= 6",
+ "npm": ">= 3"
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove Node 4 from CI - cordova-fetch
> -------------------------------------
>
> Key: CB-14066
> URL: https://issues.apache.org/jira/browse/CB-14066
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-fetch
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
