[
https://issues.apache.org/jira/browse/CB-13581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509151#comment-16509151
]
ASF GitHub Bot commented on CB-13581:
-------------------------------------
codecov-io commented on issue #366: CB-13581 open ios simulator by using
child_process
URL: https://github.com/apache/cordova-ios/pull/366#issuecomment-396448848
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=h1)
Report
> Merging
[#366](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/6e790afb0e8e7e6e427960b6e884462dc981744f?src=pr&el=desc)
will **decrease** coverage by `0.12%`.
> The diff coverage is `28.57%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 63.99% 63.86% -0.13%
==========================================
Files 14 14
Lines 1697 1702 +5
Branches 286 286
==========================================
+ Hits 1086 1087 +1
- Misses 611 615 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/366/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==)
| `25.39% <28.57%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=footer).
Last update
[6e790af...7d918e2](https://codecov.io/gh/apache/cordova-ios/pull/366?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cordova plugin after_run hook terminates before promise is resolved
> -------------------------------------------------------------------
>
> Key: CB-13581
> URL: https://issues.apache.org/jira/browse/CB-13581
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-plugins
> Affects Versions: 7.0.0
> Environment: Running Cordova 7.1.0 on macOS Sierra 10.12.6
> Reporter: Niklas Kirk Mouritzsen
> Priority: Blocker
> Labels: hooks, plugin
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> When creating a plugin that hooks itself up on the after_run hook, its is
> terminated before the promise is resolved or rejected. It is currently
> blocking our development. I've created this post on stack overflow describing
> the problem in greater detail:
> https://stackoverflow.com/questions/47288569/cordova-plugin-asynchronous-hooks-not-working
> Let me know if I can provide any additional insight in the problem, or if
> there are any known workarounds/fixes for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
