[
https://issues.apache.org/jira/browse/CB-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511659#comment-16511659
]
ASF GitHub Bot commented on CB-14125:
-------------------------------------
jcesarmobile closed pull request #449: CB-14125:(android) Increase old plugin
compatibility
URL: https://github.com/apache/cordova-android/pull/449
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/cordova/lib/pluginHandlers.js
b/bin/templates/cordova/lib/pluginHandlers.js
index f57c28379..e6d7ffdfb 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -320,8 +320,8 @@ function studioPathRemap (obj) {
if (!obj.targetDir.includes('app/src/main')) {
if (obj.src.endsWith('.java')) {
return path.join('app/src/main/java', obj.targetDir.substring(4),
path.basename(obj.src));
- } else if (obj.src.endsWith('.xml')) {
- // We are making a huge assumption here that XML files will be
going to res/xml or values/xml
+ } else {
+ // For all other files, add 'app/src/main' to the targetDir if it
didn't have it already
return path.join('app/src/main', obj.targetDir,
path.basename(obj.src));
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Increase cordova-android old plugin compatibility
> -------------------------------------------------
>
> Key: CB-14125
> URL: https://issues.apache.org/jira/browse/CB-14125
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: jcesarmobile
> Assignee: jcesarmobile
> Priority: Major
>
> With the structure change of cordova-android 7.1.0, a lot of plugins don't
> work because they user source-file tag for images or other file types.
> Right now, we only patch to the new path structure .java and .xml files.
> Add 'app/src/main' to all file types, no mater what type they have.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
