[
https://issues.apache.org/jira/browse/CB-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514998#comment-16514998
]
ASF GitHub Bot commented on CB-14141:
-------------------------------------
codecov-io commented on issue #373: CB-14141: Don't duplicate resource files in
xcodeproj
URL: https://github.com/apache/cordova-ios/pull/373#issuecomment-397855686
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=h1)
Report
> Merging
[#373](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/46da4bc34495ec7bfe13c1ec1b4074dd2e82641a?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 63.99% 64.03% +0.04%
==========================================
Files 14 14
Lines 1697 1699 +2
Branches 286 287 +1
==========================================
+ Hits 1086 1088 +2
Misses 611 611
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/373/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
| `84.72% <100%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=footer).
Last update
[46da4bc...e2c885f](https://codecov.io/gh/apache/cordova-ios/pull/373?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Should be able to overwrite CDVLaunchScreen.storyboard with resource-file in
> config.xml
> ---------------------------------------------------------------------------------------
>
> Key: CB-14141
> URL: https://issues.apache.org/jira/browse/CB-14141
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Minor
>
> It should be possible to overwrite the CDVLaunchScreen.storyboard file using
> {{resource-file}} in config.xml, but that has an unfortunate side effect of
> adding it to the Xcode project twice.
> When installing resources from config.xml {{resource-file}} tags, we should
> log a warning if the file already exists and skip adding it to the Xcode
> project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
