[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516520#comment-16516520
]
ASF GitHub Bot commented on CB-14145:
-------------------------------------
brodybits closed pull request #618: [CB-14145] npm audit in CI on 8.0.0 - TEST
WIP DO NOT MERGE
URL: https://github.com/apache/cordova-lib/pull/618
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index cc0eebf34..032a4a740 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -10,6 +10,7 @@ node_js:
before_install: if [[ `npm -v` < 3 ]]; then npm i -g npm@3; fi
install:
- npm install
+ - npm audit
# Workaround for npm/npm#10343 when dependency of linked module is moved to
dependent
# module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli'
dependency
# is moved to 'cordova-lib' and hence 'npm run jshint' on 'cordova-common'
is failing
diff --git a/appveyor.yml b/appveyor.yml
index 4c3d2982b..ab883fd3b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -10,6 +10,7 @@ environment:
install:
- ps: Install-Product node $env:nodejs_version
- npm install
+ - npm audit
# Workaround for npm/npm#10343 when dependency of linked module is moved to
dependent
# module's 'node_modules' In our case 'cordova-common' -> jshint' -> 'cli'
dependency
# is moved to 'cordova-lib' and hence 'npm run jshint' on 'cordova-common'
is failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Resolve npm audit issues
> ------------------------
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
