[ 
https://issues.apache.org/jira/browse/CB-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raphael resolved CB-9044.
-------------------------
    Resolution: Fixed

This seems to be resolved in master:

[https://github.com/apache/cordova-lib/blob/da4b4b371203777d1f951ee9580c1348ddb36659/src/hooks/HooksRunner.js#L66-L70]

Just reopen if this is not correct.

> hooks should be run sync with timeout, instead of async
> -------------------------------------------------------
>
>                 Key: CB-9044
>                 URL: https://issues.apache.org/jira/browse/CB-9044
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> for example, if you had a before_prepare hook that modified a file, 'prepare' 
> would be run before the hook has completed, resulting in an undesired state.
> https://github.com/apache/cordova-lib/blob/c080f6727d8498c3337fc3a1c57720cd1853d175/cordova-lib/src/cordova/superspawn.js#L104
> The line above shows that the hooks runner runs the hooks async. The hooks 
> should be run sync, with a timeout. This way any hooks can be properly run 
> before the operation is run (in this case, prepare).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to