[
https://issues.apache.org/jira/browse/CB-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523541#comment-16523541
]
ASF GitHub Bot commented on CB-14099:
-------------------------------------
erisu opened a new pull request #32: CB-14099 osx: Fixed Resolve Config Path
for OSX
URL: https://github.com/apache/cordova-common/pull/32
### Platforms affected
OSX
### What does this PR do?
Updates the Resolve Config Path for OSX.
I have identified that the initial build was successful but the consecutive
builds fail because it updated the incorrect `config.xml` file.
I was able to narrow down this issue coming from the `resolveConfigFilePath`
method. This method currently handles special cases for Android, Ubuntu, and
iOS. For all other platforms, it would fall back to glob for the config.xml.
This is what was happens for OSX.
When building for the first time, you have installed a fresh copy of the OSX
platform.
At this time, when globbing, it will find the correct config.xml file
located in `/.tests/<APP_NAME>/platforms/osx/<APP_NAME>/config.xml`.
In the consecutive build, when globbing, it finds and updates the incorrect
config.xml file. The file it finds is:
`/.tests/osx/<APP_NAME>/platforms/osx/build/<APP_NAME>.app/Contents/Resources/config.xml`
This is because of the folder/file order structure and globbing nature.
Since this file was created after the first build (build history), it happens
to find this file first.
### What testing has been done on this change?
- https://travis-ci.org/erisu/cordova-common/builds/396805720
I also followed the reported issue steps:
- $ cordova create myapp org.apache.myapp myapp
- $ cordova platform add osx
- I used a cloned version of `cordova-osx@master` with modified
`package.json` to use `cordova-common#CB-14099` with my fix.
- $ cordova plugin add cordova-plugin-file
- $ cordova run osx
- I ran this step 3x times.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cordova OSX - Apps not working with Plugins
> -------------------------------------------
>
> Key: CB-14099
> URL: https://issues.apache.org/jira/browse/CB-14099
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Environment: Cordova 8.0
> osx "El capitan"
>
> Reporter: Jose Antonio Silva Korhonen
> Assignee: Tobias Bocanegra
> Priority: Major
>
> It's not possible to get any app with any compatible plugins working on osx.
> 1 - Create a barebone Cordova App
> * cordova create myapp org.apache.myapp myapp
> 2 - Add osx platform
> * cordova platform add osx
> 3 - Add any plugin compatible with osx, for example cordova-plugin-file
> * cordova plugin add cordova-plugin-file
> 4 - Run the App
> * cordova run osx
> 5 - The App doesn't trigger "device ready"
> The app stays on the state "CONNECTING TO DEVICE" for ever.
> It's expect that is shown "DEVICE IS READY". If you remove all plugins from
> the app then "DEVICE IS READY" is shown
>
> On older versions of cordova osx this procedure worked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
