[
https://issues.apache.org/jira/browse/CB-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525690#comment-16525690
]
ASF GitHub Bot commented on CB-14173:
-------------------------------------
raphinesse opened a new pull request #26: CB-14173 Fix cordova
<platform|plugin> add --link
URL: https://github.com/apache/cordova-fetch/pull/26
This drops support for the untested and undocumented `link` option
which when set, caused `npm link` to be run instead of `npm install`.
However, the installed package's name cannot be extracted from the
output of `npm link`. Thus we always failed in that case.
Now, we always run `npm install` instead. This works for the use case of
`cordova <platform|plugin> add --link` since packages identified by a
local path are always installed as symbolic links by npm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-fetch nightly breaks with --link
> ----------------------------------------
>
> Key: CB-14173
> URL: https://issues.apache.org/jira/browse/CB-14173
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
> Reporter: Darryl Pogue
> Assignee: Raphael
> Priority: Major
>
> A coworker just ran this:
> {code:java}
> npx cordova platform add --link ../cordova-ios/{code}
> It failed with this error:
> {noformat}
> Warning: using prerelease version 8.0.1-nightly.2018.6.26.77b7324f
> ([email protected])
> { CordovaError: Could not determine package name from output:
> up to date in 6.878s
> [!] 3 vulnerabilities found [2885 packages audited]
> Severity: 3 low
> Run `npm audit` for more detail/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios
> /Projects/launch-cordova-test/node_modules/cordova-ios ->
> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios
> at getTargetPackageSpecFromNpmInstallOutput
> (/Projects/launch-cordova-test/node_modules/cordova-fetch/index.js:97:15)
> at _fulfilled (/Projects/launch-cordova-test/node_modules/q/q.js:854:54)
> at /Projects/launch-cordova-test/node_modules/q/q.js:883:30
> at Promise.promise.promiseDispatch
> (/Projects/launch-cordova-test/node_modules/q/q.js:816:13)
> at /Projects/launch-cordova-test/node_modules/q/q.js:624:44
> at runSingle (/Projects/launch-cordova-test/node_modules/q/q.js:137:13)
> at flush (/Projects/launch-cordova-test/node_modules/q/q.js:125:13)
> at process._tickCallback (internal/process/next_tick.js:172:11)
> name: 'CordovaError',
> message: 'Could not determine package name from output:\nup to date in
> 6.878s\n[!] 3 vulnerabilities found [2885 packages audited]\n Severity: 3
> low\n Run `npm audit` for more
> detail\n\n/usr/local/lib/node_modules/cordova-ios ->
> /Projects/cordova-ios\n/Projects/launch-cordova-test/node_modules/cordova-ios
> -> /usr/local/lib/node_modules/cordova-ios -> /Projects/cordova-ios',
> code: 0,
> context: undefined }{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
