[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529223#comment-16529223
]
ASF GitHub Bot commented on CB-14097:
-------------------------------------
jcesarmobile commented on a change in pull request #322: CB-14097: (android)
Fix crash when selecting some files with getPicture
URL:
https://github.com/apache/cordova-plugin-camera/pull/322#discussion_r199360085
##########
File path: src/android/FileHelper.java
##########
@@ -97,10 +98,19 @@ public static String
getRealPathFromURI_API11_And_Above(final Context context, f
else if (isDownloadsDocument(uri)) {
final String id = DocumentsContract.getDocumentId(uri);
- final Uri contentUri = ContentUris.withAppendedId(
- Uri.parse("content://downloads/public_downloads"),
Long.valueOf(id));
-
- return getDataColumn(context, contentUri, null, null);
+ if (!TextUtils.isEmpty(id)) {
Review comment:
Instead of using TextUtils just for checking if is empty, use `id != null &&
id.length() > 0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin crashes using getPicture on some files
> ----------------------------------------------------
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
> Reporter: B. van Mensvoort
> Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/1111}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
