[ 
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529445#comment-16529445
 ] 

Tobias Bocanegra commented on CB-13424:
---------------------------------------

bq. As a side question, do you happen to know why the PR says closed instead of 
merged?

I uses coho to prepare the PR. coho adds a {{This closes #32}} to the commit 
message:
https://github.com/apache/cordova-common/commit/7bf9627f0135c6b3518292660b6e07e6f5815926



> [cordova-osx] Not adding plugins to the osx platform
> ----------------------------------------------------
>
>                 Key: CB-13424
>                 URL: https://issues.apache.org/jira/browse/CB-13424
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-osx
>            Reporter: José Expósito
>            Assignee: Tobias Bocanegra
>            Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually 
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> <?xml version='1.0' encoding='utf-8'?>
> <widget id="io.cordova.hellocordova" version="1.0.0" 
> xmlns="http://www.w3.org/ns/widgets"; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0";>
>     [...]
>     <feature name="Device">
>         <param name="osx-package" value="CDVDevice" />
>     </feature>
>     [...]
> </widget>
> {code}
> I noticed this happens with Cordova core plugins with official macOS support 
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to