[
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535266#comment-16535266
]
ASF GitHub Bot commented on CB-13834:
-------------------------------------
brodybits closed pull request #248: [WIP] CB-13834 TEST FOR DISCUSSION [DO NOT
MERGE]
URL: https://github.com/apache/cordova-windows/pull/248
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/appveyor.yml b/appveyor.yml
index a52ea365..0291ee1e 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -24,8 +24,8 @@ image:
- Visual Studio 2017
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
+ - nodejs_version: "8"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/spec/e2e/endtoend.spec.js b/spec/e2e/endtoend.spec.js
index a06ebb9a..094a5fbb 100644
--- a/spec/e2e/endtoend.spec.js
+++ b/spec/e2e/endtoend.spec.js
@@ -39,15 +39,23 @@ describe('Cordova create and build', function () {
function verifySubDirContainsFile (subDirName, fileName, count) {
count = typeof count !== 'undefined' ? count : 1;
+ // console.log('CHECK subDirName : ' + subDirName);
+ // console.log('in appPackagesFolder: ' + appPackagesFolder);
+
var subDir = path.join(appPackagesFolder, subDirName);
var packages = shell.ls(subDir);
+ // packages.map(function (file) { console.log('file name: ' + file);
});
expect(packages.filter(function (file) { return file.match(fileName);
}).length).toBe(count);
}
function _expectExist (fileNamePattern, count) {
count = typeof count !== 'undefined' ? count : 1;
+ // console.log('CHECK fileNamePattern: ' + fileNamePattern);
+ // console.log('in appPackagesFolder: ' + appPackagesFolder);
+
var packages = shell.ls(appPackagesFolder);
+ // packages.map(function (file) { console.log('file name: ' + file);
});
expect(packages.filter(function (file) { return
file.match(fileNamePattern); }).length).toBe(count);
}
@@ -59,6 +67,8 @@ describe('Cordova create and build', function () {
}
beforeEach(function () {
+ shell.cd(buildDirectory);
+ shell.rm('-rf', projectFolder);
shell.exec(path.join('bin', 'create') + ' "' + projectFolder + '"
com.test.app 応用', {silent: silent});
});
@@ -203,7 +213,7 @@ describe('Cordova create and build', function () {
// here be 6a
- it('spec.6b should generate appxupload and appxbundle for Windows 10
project bundle release build', function () {
+ it('spec.6b should generate appxupload and appxbundle for Windows Phone
8.1 project bundle release build (all target platforms)', function () {
shell.exec(buildScriptPath + ' --release --appx=8.1-phone --bundle
--archs=\"x64 x86 arm\"', {silent: silent});
_expectExist(/.*bundle\.appxupload$/, 3);
_expectSubdirAndFileExist('CordovaApp.Phone_1.0.0.0_Test',
'CordovaApp.Phone_1.0.0.0_x64_x86_arm.appxbundle');
@@ -229,10 +239,30 @@ describe('Cordova create and build', function () {
_expectSubdirAndFileExist('CordovaApp.Phone_1.0.0.0_x86_Test',
'CordovaApp.Phone_1.0.0.0_x86.appx');
});
+ it('spec.6pre1 should generate appxupload and appxbundle for Windows 10
project bundle release build (x64 only)', function () {
+ shell.exec(buildScriptPath + ' --release --bundle --archs=\"x64\"',
{silent: silent});
+ _expectExist(/.*bundle\.appxupload$/, 1);
+ _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test',
'CordovaApp.Windows10_1.0.0.0_x64.appxbundle');
+ });
+
+ it('spec.6pre2 should generate appxupload and appxbundle for Windows 10
project bundle release build (x86 only)', function () {
+ shell.exec(buildScriptPath + ' --release --bundle --archs=\"x86\"',
{silent: silent});
+ _expectExist(/.*bundle\.appxupload$/, 1);
+ _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test',
'CordovaApp.Windows10_1.0.0.0_x86.appxbundle');
+ });
+
+ it('spec.6pre3 should generate appxupload and appxbundle for Windows 10
project bundle release build (arm only)', function () {
+ shell.exec(buildScriptPath + ' --release --bundle --archs=\"arm\"',
{silent: silent});
+ _expectExist(/.*bundle\.appxupload$/, 1);
+ _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test',
'CordovaApp.Windows10_1.0.0.0_arm.appxbundle');
+ });
+
// this will be move up again when it is fixed for VS 2017
- it('spec.6a should generate appxupload and appxbundle for Windows 10
project bundle release build', function () {
+ it('spec.6a should generate appxupload and appxbundle for Windows 10
project bundle release build (all target platforms)', function () {
shell.exec(buildScriptPath + ' --release --bundle --archs=\"x64 x86
arm\"', {silent: silent});
_expectExist(/.*bundle\.appxupload$/, 3);
+ // _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test',
'CordovaApp.Windows10_1.0.0.0_x64.appxbundle'); // XXX SHOULD NOT SUCCEED
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test',
'CordovaApp.Windows10_1.0.0.0_x64_x86_arm.appxbundle');
});
+
});
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AppVeyor: VS17 env test failure: "The process cannot access the file
> 'Default.rd.xml'"
> --------------------------------------------------------------------------------------
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Jan Piotrowski (Sujan)
> Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing
> test failures on AppVeyor when Visual Studio 2017 is used to build with
> params `--release --bundle --archs="x64 x86 arm"`.
>
> {code:java}
> Started
> Creating Cordova Windows Project:
> Path: testcreate 応用
> Namespace: com.test.app
> Name: 応用
> Windows project created with cordova-windows@5.1.0-dev
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x64
> Patching 10 in prebuild event...
> Injected base.js reference to the www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.WinJS.2.0\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.Phone.WinJS.2.1\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
> Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x86
> Patching 10 in prebuild event...
> C:\Program Files
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
> error MSB3231: Unable to remove directory
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file
> 'Default.rd.xml' because it is being used by another process.
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
> C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155
> throw e;
> ^
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed
> with exit code 1
> at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate
> 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
> at emitTwo (events.js:106:13)
> at ChildProcess.emit (events.js:191:7)
> at maybeClose (internal/child_process.js:920:16)
> at Process.ChildProcess._handle.onexit
> (internal/child_process.js:230:5){code}
> Afaik this is the only test that is "touching" that file (--release and
> Windows 10), so this might be a general problem.
> Note: The test `6a` that is failing because of this has been moved to the end
> of the test file so the other tests can run before it crashed - move back up
> to its normal location when this is fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
