[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537831#comment-16537831
]
ASF GitHub Bot commented on CB-14145:
-------------------------------------
brodybits closed pull request #10: CB-14145 update dependencies
URL: https://github.com/apache/cordova-node-xcode/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index a228c67..a04d828 100644
--- a/README.md
+++ b/README.md
@@ -54,9 +54,10 @@ grammar. Other tests will use the prebuilt parser
(`lib/parser/pbxproj.js`).
To rebuild the parser js file after editing the grammar, run:
- ./node_modules/.bin/pegjs lib/parser/pbxproj.pegjs
+ npm run pegjs
-(easier if `./node_modules/.bin` is in your path)
+(and be sure to restore the Apache license notice in
+`lib/parser/pbxproj.js` before committing)
## License
diff --git a/package.json b/package.json
index 00a67da..7fc751e 100644
--- a/package.json
+++ b/package.json
@@ -11,14 +11,15 @@
"node": ">=0.6.7"
},
"dependencies": {
- "pegjs": "^0.10.0",
"simple-plist": "^0.2.1",
"uuid": "3.0.1"
},
"devDependencies": {
- "nodeunit": "^0.11.0"
+ "nodeunit": "^0.11.3",
+ "pegjs": "^0.10.0"
},
"scripts": {
+ "pegjs": "node_modules/.bin/pegjs lib/parser/pbxproj.pegjs",
"test": "node_modules/.bin/nodeunit test/parser test"
},
"license": "Apache-2.0",
@@ -43,7 +44,5 @@
{
"name": "Bob Easterday"
}
-
]
-
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Resolve npm audit issues
> ------------------------
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-ios,
> cordova-js, cordova-lib, cordova-osx, cordova-plugman, cordova-windows
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
