[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543379#comment-16543379
]
ASF GitHub Bot commented on CB-14166:
-------------------------------------
raphinesse commented on issue #622: CB-14166: (cli) Fixed issue when installing
plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-404876700
@oliversalzburg Being able to run .bat and .cmd files on Windows is the
reason for spawning a shell AFAIK. [The Node.js docs
state](https://nodejs.org/api/child_process.html#child_process_spawning_bat_and_cmd_files_on_windows)
> When running on Windows, .bat and .cmd files can be invoked using
child_process.spawn() with the shell option set, with child_process.exec(), or
by spawning cmd.exe and passing the .bat or .cmd file as an argument (which is
what the shell option and child_process.exec() do).
To me, this seems to contradict your statement. I have done no testing
though. I proposed the use of a userland library because I was under the
impression that there is no easy way to achieve what we want built into
Node.js. I'd be happy to be proven wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
