[
https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543652#comment-16543652
]
wvengen edited comment on CB-14188 at 7/16/18 10:45 AM:
--------------------------------------------------------
Success on Android. Work in progress on branch below. -Pending: configuration
option, and iOS.-
[https://github.com/q-m/cordova-plugin-inappbrowser/tree/feature/beforeload-event]
was (Author: wvengen):
Success on Android. Work in progress on branch below. Pending: configuration
option, and iOS.
[https://github.com/q-m/cordova-plugin-inappbrowser/tree/feature/beforeload-event]
> Callback to decide whether to open link or not.
> -----------------------------------------------
>
> Key: CB-14188
> URL: https://issues.apache.org/jira/browse/CB-14188
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-plugin-inappbrowser
> Affects Versions: 3.0.0
> Reporter: wvengen
> Priority: Major
>
> Several times I've found myself wanting to tell inAppBrowser whether it can
> open a link in the embedded webview or using the system web browser. It would
> be great if there's a callback _before_ loading a page (loadstart is too late
> there), where I can tell inAppBrowser to load the page or not.
> CB-14013 introduced AllowedSchemes, but excluded the use of http and https.
> -It would be useful to allow intercepting http and https links, e.g. to
> decide whether to open the link in the system web browser or not.- At first I
> thought this mechanism could be used, but because of the asynchronous nature
> of Cordova callbacks, this didn't work out, and I added a beforeload
> callback. See comment for an example.
> I plan to submit a PR soonish -(my approach would be to generate a regexp
> based on AllowedSchemes and match the URL on that, instead of the current if
> logic)-.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
