[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545458#comment-16545458
]
ASF GitHub Bot commented on CB-14166:
-------------------------------------
dpogue commented on issue #622: CB-14166: (cli) Fixed issue when installing
plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-405308302
Sorry, it's hard to keep track of what works/doesn't work with/without this
change. It's hard for me to verify because I don't have a Windows machine set
up at the moment.
Could someone make an attempt to fill in the following table with ✅or ❌for
behaviour on master with various shells and with this PR for various shells?
| | master | this PR |
|-|-|-|
|**cmd.exe** | | |
| **PowerShell** | | |
| **Git Bash** | | |
| **Bash/Linux subsystem** | | |
Let's capture the current state of things, and then figure out which states
the tests are covering, and then figure out what to do going forward.
<details><summary>Table markup for copying</summary>
```
| | master | this PR |
|--------------------------|--------|---------|
| **cmd.exe** | | |
| **PowerShell** | | |
| **Git Bash** | | |
| **Bash/Linux subsystem** | | |
```
</summary>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
