[
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548894#comment-16548894
]
ASF GitHub Bot commented on CB-14187:
-------------------------------------
wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to
allow custom schemes
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406176669
Thanks for testing. Apparently I didn't test it enough, sorry. Still, for me
it works on iOS, except that sometimes the alert _Result verified_ is shown
twice. That is because, apparently, the loadstop event is being fired for
customscheme as well. I don't see how that can be avoided, as in
[`webViewDidFinishLoad`](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L463)
(nor the [originating
method](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L946))
there is no context about the URL that caused it.
My proposal:
1. Mention `loadstop` being called for `customscheme` in the documentation
(an extra `iOS quirks` in
[addEventListener](https://github.com/apache/cordova-plugin-inappbrowser#inappbrowseraddeventlistener)).
2. In the test, only navigate to the custom URL at the first time it happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --------------------------------------------------
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-plugin-inappbrowser
> Affects Versions: 3.0.0
> Reporter: wvengen
> Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes
> preference. This only works on Android, however. It would be very useful to
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
