[
https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Brody updated CB-14224:
-----------------------------
Description:
Running {{coho audit-license-headers -r windows}} gives a message that
{{template/Properties/Default.rd.xml}} is missing the license header. From a
quick search I found {{Default.rd.xml}} in [Microsoft /
Windows-universal-samples / SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
which is exactly the same except for a {{http}} link that was updated to
{{https}} _(update: old {{http}} link in GitHub, no need to update this one)_.
I would like to propose the following changes:
* -Updated {{https}} link from [Microsoft / Windows-universal-samples /
SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]-
* Include license text from [Microsoft / Windows-universal-samples / LICENSE
(github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
(with left alignment fixed)
* Link to [Microsoft / Windows-universal-samples / SharedContent / cs /
Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
in {{template/Properties/Default.rd.xml}}
was:
Running {{coho audit-license-headers -r windows}} gives a message that
{{template/Properties/Default.rd.xml}} is missing the license header. From a
quick search I found {{Default.rd.xml}} in [Microsoft /
Windows-universal-samples / SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
which is exactly the same except for a {{http}} link that was updated to
{{https}}. I would like to propose the following changes:
* -Updated {{https}} link from [Microsoft / Windows-universal-samples /
SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]-
* Include license text from [Microsoft / Windows-universal-samples / LICENSE
(github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
(with left alignment fixed)
* Link to [Microsoft / Windows-universal-samples / SharedContent / cs /
Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
in {{template/Properties/Default.rd.xml}}
> template/Properties/Default.rd.xml needs license header & other updates
> -----------------------------------------------------------------------
>
> Key: CB-14224
> URL: https://issues.apache.org/jira/browse/CB-14224
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that
> {{template/Properties/Default.rd.xml}} is missing the license header. From a
> quick search I found {{Default.rd.xml}} in [Microsoft /
> Windows-universal-samples / SharedContent / cs / Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
> which is exactly the same except for a {{http}} link that was updated to
> {{https}} _(update: old {{http}} link in GitHub, no need to update this
> one)_. I would like to propose the following changes:
> * -Updated {{https}} link from [Microsoft / Windows-universal-samples /
> SharedContent / cs / Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]-
> * Include license text from [Microsoft / Windows-universal-samples / LICENSE
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
> (with left alignment fixed)
> * Link to [Microsoft / Windows-universal-samples / SharedContent / cs /
> Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blame/master/SharedContent/cs/Default.rd.xml]
> in {{template/Properties/Default.rd.xml}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
