Chris Brody created CB-14225:
--------------------------------

             Summary: Fix sample namespace Serialize attribute in 
template/Properties/Default.rd.xml
                 Key: CB-14225
                 URL: https://issues.apache.org/jira/browse/CB-14225
             Project: Apache Cordova
          Issue Type: Improvement
          Components: cordova-windows
            Reporter: Chris Brody
            Assignee: Chris Brody


If I would generate a new UWP C# project using Visual Studio 2017 and copy the 
generated {{Default.rd.xml}} file into {{template\Properties}} then I would see 
the following diff:
{code:xml}
index 7c40ffeb..af00722c 100644
--- a/template/Properties/Default.rd.xml
+++ b/template/Properties/Default.rd.xml
@@ -12,7 +12,7 @@
     <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" 
Activate="Required Public" />

     Using the Namespace directive to apply reflection policy to all the types 
in a particular namespace
-    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
+    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
 -->

 <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata";>
{code}

I propose to commit this change to the master branch.

Related:
* CB-12499 - introduced {{template/Properties/Default.rd.xml}}
* CB-14224 - proposal to add license text to the header
* 
[Microsoft/Windows-universal-samples#950|https://github.com/Microsoft/Windows-universal-samples/pull/950]
 - similar proposal for [Microsoft / 
Windows-universal-samples|https://github.com/Microsoft/Windows-universal-samples]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to