[
https://issues.apache.org/jira/browse/CB-14074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566233#comment-16566233
]
ASF GitHub Bot commented on CB-14074:
-------------------------------------
brodybits closed pull request #375: CB-14074 ios: Remove Node 4 support from CI
& package.json
URL: https://github.com/apache/cordova-ios/pull/375
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index d8fbb6f1f..a915fe10c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,30 +4,27 @@ sudo: false
env:
matrix:
- - TRAVIS_NODE_VERSION: '4.8.7'
- - TRAVIS_NODE_VERSION: '6.13'
- - TRAVIS_NODE_VERSION: '8'
- - TRAVIS_NODE_VERSION: '10'
+ - TRAVIS_NODE_VERSION: '6'
+ - TRAVIS_NODE_VERSION: '8'
+ - TRAVIS_NODE_VERSION: '10'
before_install:
-- npm cache clean -f
-- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm &&
(cd ~/.nvm
- && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh &&
nvm
- install $TRAVIS_NODE_VERSION
-- node --version
+ - nvm install $TRAVIS_NODE_VERSION
install:
-- npm install
-- npm install ios-deploy
-- npm install -g codecov
+ - npm install
+ - npm install ios-deploy
+ - npm install -g codecov
script:
- - npm run unit-tests
- - npm run e2e-tests
- - open -b com.apple.iphonesimulator
- - npm run objc-tests
- - npm run cover
- - npm run eslint
+ - node --version
+ - npm --version
+ - npm run unit-tests
+ - npm run e2e-tests
+ - open -b com.apple.iphonesimulator
+ - npm run objc-tests
+ - npm run cover
+ - npm run eslint
after_script:
- - codecov
+ - codecov
diff --git a/appveyor.yml b/appveyor.yml
index 2a36faaa3..b37532e86 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,6 +1,5 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "10"
diff --git a/package.json b/package.json
index bc28cbc2a..6807ed8a7 100644
--- a/package.json
+++ b/package.json
@@ -46,8 +46,9 @@
"tmp": "^0.0.26"
},
"engines": {
- "node": ">=4"
+ "node": ">=6"
},
+ "engineStrict": true,
"dependencies": {
"cordova-common": "2.1.0",
"ios-sim": "^6.1.2",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove Node 4 support - cordova-ios
> -----------------------------------
>
> Key: CB-14074
> URL: https://issues.apache.org/jira/browse/CB-14074
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
> Reporter: Darryl Pogue
> Assignee: Chris Brody
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
