[
https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566354#comment-16566354
]
ASF GitHub Bot commented on CB-14242:
-------------------------------------
codecov-io commented on issue #388: CB-14242 remove bundledDependencies and
committed node_modules
URL: https://github.com/apache/cordova-ios/pull/388#issuecomment-409807256
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=h1)
Report
> Merging
[#388](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/f628f61d90a8d27613b5b6e46e3b54d5b4358955?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 65.62% 65.62%
=======================================
Files 14 14
Lines 1702 1702
Branches 286 286
=======================================
Hits 1117 1117
Misses 585 585
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=footer).
Last update
[f628f61...63f069f](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove bundledDependencies & committed node_modules from cordova-ios
> --------------------------------------------------------------------
>
> Key: CB-14242
> URL: https://issues.apache.org/jira/browse/CB-14242
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is
> marked ([email protected]) and CB-14074 (remove Node.js 4 from
> cordova-ios package.json & CI) is committed it is time to:
> * remove {{bundledDependencies}} entry from {{package.json}}
> * remove the committed {{node_modules}}
> * fix {{.gitignore}} to completely ignore {{node_modules}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
