[
https://issues.apache.org/jira/browse/CB-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566568#comment-16566568
]
ASF GitHub Bot commented on CB-14075:
-------------------------------------
erisu commented on a change in pull request #289: CB-14075: (windows) Remove
Node 4 from CI - cordova-windows
URL: https://github.com/apache/cordova-windows/pull/289#discussion_r207170402
##########
File path: .travis.yml
##########
@@ -1,15 +1,21 @@
language: node_js
sudo: false
+
git:
depth: 10
+
node_js:
- - "4"
- "6"
+ - "8"
+ - "10"
+
install:
- - npm install
- - npm install -g codecov
+ - npm install
Review comment:
I noticed some were indented with 2 spaces while others were 4. Typically I
indent things with 2 spaces also, so I went ahead and modified them to at least
be in uniform with the others.
There are no problems if I had left it alone. Travis CI, at least, does not
enforce an indention rule for their YAML files while others have been known to
enforce two space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove Node 4 from CI - cordova-windows
> ---------------------------------------
>
> Key: CB-14075
> URL: https://issues.apache.org/jira/browse/CB-14075
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-windows
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
