[
https://issues.apache.org/jira/browse/CB-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567374#comment-16567374
]
ASF GitHub Bot commented on CB-14249:
-------------------------------------
janpio commented on a change in pull request #189: CB-14249 ensure platform
changes are in a dev version (partial workaround doc fix)
URL: https://github.com/apache/cordova-coho/pull/189#discussion_r207339161
##########
File path: docs/platforms-release-process.md
##########
@@ -122,6 +123,10 @@ Double check you replace "Android" in the subject and
mail body - there is no un
Note that it would be possible to continue with some of the [Before
Release](#before-release) items while waiting for a possible response.
+### Ensure changes are in a dev version
+
+The procedure described here may leave non-master branch with a non-dev
version number. Functional changes should always be done in a "-dev" version.
Please mark the "-dev" version manually or using cordova-coho before making
changes, and test it especially when marking "-dev" version manually.
Review comment:
What is the `cordova-coho` command to use?
Where does one have to change things when doing this manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inconsistency in platforms vs tools release in cordova-coho docs
> ----------------------------------------------------------------
>
> Key: CB-14249
> URL: https://issues.apache.org/jira/browse/CB-14249
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> The procedure for tools release is that once the tools release is made,
> version must be incremented to new -dev version. This does not seem to be the
> case for platforms release.
> I think we did not catch this for a long time since the coho tools
> automatically marks new "-dev" version in master, in case of release from
> master. But in case of release from non-master branch this does not seem to
> be the case.
> This should be relatively straightforward except for another factor: in case
> a proposed release does not pass the vote the procedure is different: for
> tools it says we should go on with the next release while for platforms it
> says we should do a revert to go back to the previous "-dev" before fixing. I
> think this inconsistency should also be resolved, somehow.
> As a workaround I would mark the "-dev" version in a patch branch before
> committing any changes to a non-master branch, for example:
> https://github.com/apache/cordova-android/pull/470
> P.S. I think it would be best to get agreement via
> [mailto:[email protected]], cannot tell for sure when I will get a
> chance to do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
