[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576580#comment-16576580
]
ASF GitHub Bot commented on CB-13772:
-------------------------------------
janpio closed pull request #291: CB-13772: print version numbers correctly in
"cordova requirements"
URL: https://github.com/apache/cordova-cli/pull/291
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cli.js b/src/cli.js
index 7791b303..865231c7 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -397,7 +397,7 @@ function cli (inputArgs) {
platformCheck.forEach(function (checkItem) {
var checkSummary = checkItem.name + ': ' +
(checkItem.installed ? 'installed ' : 'not
installed ') +
- (checkItem.metadata.version || '');
+ (checkItem.installed ?
checkItem.metadata.version.version || checkItem.metadata.version : '');
events.emit('log', checkSummary);
if (!checkItem.installed) {
someChecksFailed = true;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
> ----------------------------------------------------------------------------------------
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: [email protected]
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
> Reporter: Darcy Meyer
> Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
