[
https://issues.apache.org/jira/browse/CB-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589378#comment-16589378
]
ASF subversion and git services commented on CB-14234:
------------------------------------------------------
Commit cf58b04097ad53151f4c456d0fef27dd5cecd966 in
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpolivy]
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=cf58b04
]
CB-14234: Don't call handleOpenURL for system URLs (#278)
When calling `.open()` with a target of `_system`, the InAppBrowser on iOS is
both launching the URL in the system browser AND also broadcasting to open the
URL within the app (calling handleOpenURL). The latter behavior is problematic
in many circumstances (e.g. when you want to explicitly open a link in a
browser which is a universal link handled by the app).
This commit attempts to address this by checking the return value from openURL
-- if it does not open the URL successfully, then (and only then) the code
falls back to broadcasting the event within the app to handleOpenURL.
> InAppBrowser iOS calls handleOpenURL in same app for _system URLs
> -----------------------------------------------------------------
>
> Key: CB-14234
> URL: https://issues.apache.org/jira/browse/CB-14234
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Affects Versions: 3.0.0
> Reporter: Dan Polivy
> Priority: Minor
>
> The change to fix CB-11178 has caused some undesirable behavior with
> InAppBrowser on iOS. Now, whenever you try to open a URL in the system
> browser, by calling `cordova.InAppBrowser.open(url, "_system")`, it opens the
> system browser AND calls `handleOpenURL` _in your app_ with the same URL.
> In my case, my app is a URL handler for a corresponding web domain (app
> links). I am trying to open a page on this web domain in the system browser
> from within my app. If my app's handleOpenURL is called with a URL also on
> the domain, then my handler thinks it is handling an app link and it causes
> the app to navigate to another URL, which in this case is not desired or
> expected.
> Prior to the fix for CB-11178, this worked perfectly. Is there any other way
> to address the fix for CB-11178 without inheriting this incorrect and
> undesirable behavior?
> [~jcesarmobile]: FYI as you committed the fix in question.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
