[
https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599905#comment-16599905
]
ASF subversion and git services commented on CB-14224:
------------------------------------------------------
Commit 03f482dfee44809b9e289af3721eccb31884bc53 in cordova-windows's branch
refs/heads/master from [~brodybits]
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=03f482d ]
CB-14225 fix sample Namespace Serialize attribute in
template/Properties/Default.rd.xml (#286)
### Original issue
<https://issues.apache.org/jira/browse/CB-14225>
### Platforms affected
Windows
### What does this PR do?
- Fix sample Namespace Serialize attribute in
`template/Properties/Default.rd.xml`, according to `Default.rd.xml` in C# UWP
project generated by Visual Studio 2017
I also raised <https://github.com/Microsoft/Windows-universal-samples/pull/950>
to apply a similar fix there.
Also related:
- #284 - fix license text & add link to `template/Properties/Default.rd.xml`
(as reported in <https://issues.apache.org/jira/browse/CB-14224>)
- <https://github.com/Microsoft/Windows-universal-samples/pull/949> - fix
license txt (related to but not part of #284)
### What testing has been done on this change?
- Visual inspection
- check diff
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in
the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- ~~Added automated test coverage as appropriate for this change.~~
> template/Properties/Default.rd.xml needs license header
> -------------------------------------------------------
>
> Key: CB-14224
> URL: https://issues.apache.org/jira/browse/CB-14224
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that
> {{template/Properties/Default.rd.xml}} is missing the license header. From a
> quick search I found {{Default.rd.xml}} in [Microsoft /
> Windows-universal-samples / SharedContent / cs / Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
> which is exactly the same except for a {{http}} link that was updated to
> {{https}} _(update: old {{http}} link in GitHub, no need to update this
> one)_. I would like to propose the following changes:
> * -Updated {{https}} link from [Microsoft / Windows-universal-samples /
> SharedContent / cs / Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
> * Include license text from [Microsoft / Windows-universal-samples / LICENSE
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
> (with left alignment fixed)
> * Link to [Microsoft / Windows-universal-samples / SharedContent / cs /
> Default.rd.xml
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
> in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised
> [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
> to cleanup (and rename) its LICENSE file. This may influence the exact
> LICENSE text we should include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in
> CB-14225_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
