[
https://issues.apache.org/jira/browse/CB-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601830#comment-16601830
]
ASF GitHub Bot commented on CB-14172:
-------------------------------------
raphinesse commented on issue #25: CB-14172: Disable save-exact explicitly
URL: https://github.com/apache/cordova-fetch/pull/25#issuecomment-418022458
I agree with @dpogue here. We should only override user preferences if it's
absolutely necessary to achieve our goal. Which in turn means we should not
test behavior of npm, that we did not enforce e. g. by passing a command line
option to it.
My refactoring PR of the pkgJson-restore.spec in lib already removes some of
that testing. Any issues flagging the tests we need to fix this would be highly
appreciated. Thanks for bringing this to our attention @oliversalzburg!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> save-exact preferences from .npmrc should be overridden
> -------------------------------------------------------
>
> Key: CB-14172
> URL: https://issues.apache.org/jira/browse/CB-14172
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
> Affects Versions: 1.3.0
> Reporter: Oliver Salzburg
> Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When I add `save-exact=true` to my `.npmrc` and run the test suite for
> cordova-fetch, it will fail, because the exact 5.1.1 version will be
> persisted to the `package.json` instead of the expected semver range `^5.1.1`.
> `save-exact` should be disabled explicitly by default unless the related
> option was provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
