[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605343#comment-16605343
]
ASF GitHub Bot commented on CB-13496:
-------------------------------------
codecov-io edited a comment on issue #45: CB-13496: Fix greedy regex in
plist-helpers
URL: https://github.com/apache/cordova-common/pull/45#issuecomment-418984278
#
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=h1)
Report
> Merging
[#45](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-common/commit/446adc1536ea8e9ac44dca8a3554b452d07aad64?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 19 19
Lines 1730 1730
Branches 360 360
=======================================
Hits 1492 1492
Misses 238 238
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/util/plist-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/45/diff?src=pr&el=tree#diff-c3JjL3V0aWwvcGxpc3QtaGVscGVycy5qcw==)
| `81.39% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=footer).
Last update
[446adc1...22e79cc](https://codecov.io/gh/apache/cordova-common/pull/45?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> the plugin config-file tag for iOS plist array behaves unnaturally.
> -------------------------------------------------------------------
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
> Affects Versions: 2.1.0
> Environment: Mac OSX
> Reporter: Ken Naito
> Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
