[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610631#comment-16610631
]
ASF GitHub Bot commented on CB-14089:
-------------------------------------
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216679161
##########
File path: bin/templates/project/app/build.gradle
##########
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+ classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
@joshchandler Sorry, the `cdvHelpers` is currently not available in the
`dependencies` scope, as I mentioned in this example.
Wrapping the apply plugin should be OK. Example:
```
if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
apply plugin: 'kotlin-android'
}
```
There is a discussion on a PR that also modifies the the same `build.gradle`
file for other features. It also had the same issue where `cdvHelpers` is not
available in the dependency scope. Adding it is as easy as adding the `apply
from: '../CordovaLib/cordova.gradle'` in the scope BUT I am waiting for any
feedback about it.
You can see the comment here:
https://github.com/apache/cordova-android/pull/438#discussion_r216195552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Kotlin Support
> ------------------
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
> Reporter: Joshua Chandler
> Assignee: Joe Bowser
> Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
