[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628009#comment-16628009
]
ASF GitHub Bot commented on CB-13740:
-------------------------------------
purplecabbage closed pull request #335: CB-13740 safe requirements check
URL: https://github.com/apache/cordova-cli/pull/335
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cli.js b/src/cli.js
index 77cdbbd2..26082975 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -381,17 +381,21 @@ function cli (inputArgs) {
}
var someChecksFailed = false;
- platformCheck.forEach(function (checkItem) {
- var checkSummary = checkItem.name + ': ' +
- (checkItem.installed ? 'installed ' : 'not
installed ') +
- (checkItem.installed ?
checkItem.metadata.version.version || checkItem.metadata.version : '');
- events.emit('log', checkSummary);
- if (!checkItem.installed) {
- someChecksFailed = true;
- events.emit('warn', checkItem.metadata.reason);
- }
- });
+ // platformCheck is expected to be an array of conditions
that must be met
+ // the browser platform currently returns nothing, which
was breaking here.
+ if (platformCheck && platformCheck.forEach) {
+ platformCheck.forEach(function (checkItem) {
+ var checkSummary = checkItem.name + ': ' +
+ (checkItem.installed ? 'installed ' : 'not
installed ') +
+ (checkItem.installed ?
checkItem.metadata.version.version || checkItem.metadata.version : '');
+ events.emit('log', checkSummary);
+ if (!checkItem.installed) {
+ someChecksFailed = true;
+ events.emit('warn', checkItem.metadata.reason);
+ }
+ });
+ }
return someChecksFailed;
}).some(function (isCheckFailedForPlatform) {
return isCheckFailedForPlatform;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
> ----------------------------------------------------------------------------
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
> Reporter: Sasha Kalmikov
> Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map (<anonymous>)
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
