[
https://issues.apache.org/jira/browse/CB-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634039#comment-16634039
]
ASF GitHub Bot commented on CB-13208:
-------------------------------------
janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to
only read the requested range
URL:
https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-425912291
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> File plugin on Windows reads entire file into memory when only a small
> fragment is requested on `readAsBinaryString`
> --------------------------------------------------------------------------------------------------------------------
>
> Key: CB-13208
> URL: https://issues.apache.org/jira/browse/CB-13208
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Affects Versions: 6.5.0
> Environment: All Windows UAP applications
> Reporter: Samer Albahra
> Priority: Major
>
> `readAsBinaryString` for `FileReader` on Windows is reading the entire file
> to a buffer then slicing the requested fragment causing the app to crash due
> to out of memory errors. It should instead be using a stream which seeks to
> the requested start position and only reads the requested length.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
