[
https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637220#comment-16637220
]
ASF GitHub Bot commented on CB-12468:
-------------------------------------
IvanProdaiko94 opened a new pull request #213: CB-12468 added ability to
set|get default options;
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213
While using plugin I must set popup features only when calling window.open
method. But a lot of libraries (firebase, openFB) use window.open inside their
own code where I can't directly menage the features of window to be opened, and
on IOS, where we do not a have a 'back' button we could have a problem. For
example window, opened with 'toolbar=no' will make app to stack with no ability
to close the window. Another thing to be mentioned is when on IOS you use
<video inline> attribute, after opening a new window without setting
'allowInlineMediaPlayback=yes' all inline attributes will stop working properly
and video will start to open in a fullscreen mode.
So, my proposal is to provide an ability to setDefaultOptions method that
will help to prevent external libraries to manage the options of of window to
be opened directly. If pass a '(required)' in option like that
'location=no(required)' than any option provided in window.open method will not
affect on the default settings.
I tested it in my projects (IOS|Android), and everything works fine;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-inappbrowser-plugin setDefaultOptions method
> ----------------------------------------------------
>
> Key: CB-12468
> URL: https://issues.apache.org/jira/browse/CB-12468
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-lib
> Affects Versions: 3.5.0
> Environment: IOS/Android
> Reporter: Ivan Prodaiko
> Priority: Major
> Labels: features
> Fix For: Master
>
>
> While using cordova-inappbrowser-plugin I must set popup features only when
> calling window.open method. But a lot of libraries (firebase, openFB) use
> window.open inside their own code where I can't directly menage the features
> of window to be opened, and on IOS, where we do not a have a 'back' button we
> could have a problem. For example window, opened with 'toolbar=no' will make
> app to stack with no ability to close the window. Another thing to be
> mentioned is when on IOS you use <video inline> attribute, after opening a
> new window without setting 'allowInlineMediaPlayback=yes' all inline
> attributes will stop working properly and video will start to open in a
> fullscreen mode.
> So, my proposal is to provide an ability to setDefaultOptions method that
> will help to prevent external libraries to manage the options of of window to
> be opened directly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
