[ 
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637230#comment-16637230
 ] 

ASF GitHub Bot commented on CB-13774:
-------------------------------------

carcus88 opened a new pull request #164: CB-13774: repair broken recording and 
playback functionality on Android
URL: https://github.com/apache/cordova-plugin-media/pull/164
 
 
   Revert back to plugins original use of DEFAULT as the audio encode and 
decoder.
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
   is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Puts the media encoder/decoder back to DEFAULT
   
   ### What testing has been done on this change?
   
   I created a repo that shows the current media plugin failing. Applying the 
code in this pull request will show it passing.
   
   https://github.com/medsurvey/cordova-media-bug
   
   The problem seems to be that somehow the encoder and decoder are set to 
different encoding types and are not compatible. Additionally its assuming an 
encoder is available on the platform and since the interface to the this object 
does not allow a way to specifying encoding I feel like the default may have 
been more appropriate. 
   
   ### Checklist
   *Could not complete these as I don't have access*
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
   - [] Added automated test coverage as appropriate for this change.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> cordova-plugin-media broken recording and playback functionality 
> -----------------------------------------------------------------
>
>                 Key: CB-13774
>                 URL: https://issues.apache.org/jira/browse/CB-13774
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-media
>         Environment: Android
>            Reporter: Mark Mitchell
>            Priority: Blocker
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to 
> different encoding types and are not compatible. Additionally its assuming an 
> encoder is available on the platform and since the interface to the this 
> object does not allow a way to specifying encoding I feel like the default 
> may have been more appropriate. 
> Currently the code is as follows 
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); // 
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to