[
https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637236#comment-16637236
]
ASF GitHub Bot commented on CB-11714:
-------------------------------------
DisruptiveMind opened a new pull request #242: CB-11714: (windows) added check
for encoding in savePhoto() without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows 10
### What does this PR do?
Adds extra content-type check when capturing photos without specifying
targetWidth and/or targetHeight in options to preserve JPEG file extension.
### What testing has been done on this change?
ditto
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Camera plugin for windows does not properly set content-type when selecting
> JPG->PNG
> ------------------------------------------------------------------------------------
>
> Key: CB-11714
> URL: https://issues.apache.org/jira/browse/CB-11714
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Affects Versions: Master
> Environment: Windows 10
> Reporter: Tyler Pham
> Priority: Major
> Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the
> resizeImage() will not modify the target content type when converting
> canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a
> .png extension which will cause the browser to not render to image and issue
> an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
