[
https://issues.apache.org/jira/browse/CB-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737064#comment-16737064
]
Sudhish commented on CB-12492:
------------------------------
edit-config is not working in config.xml in cordova.
*Ionic:*
ionic (Ionic CLI) : 4.5.0
Ionic Framework : @ionic/angular 4.0.0-rc.0
@angular-devkit/build-angular : 0.11.4
@angular-devkit/schematics : 7.1.4
@angular/cli : 7.1.4
@ionic/angular-toolkit : 1.2.0
*Cordova:*
cordova (Cordova CLI) : 8.0.0
Cordova Platforms : none
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.3,
cordova-plugin-ionic-webview 2.2.3, (and 18 other plugins)
*System:*
ios-deploy : 1.9.2
NodeJS : v8.11.4 (/usr/local/bin/node)
npm : 5.6.0
OS : macOS High Sierra
> plugin.xml edit-config not working for attributes on manifest/application
> -------------------------------------------------------------------------
>
> Key: CB-12492
> URL: https://issues.apache.org/jira/browse/CB-12492
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-common
> Affects Versions: 2.0.0
> Reporter: Matthias
> Assignee: Filip Maj
> Priority: Major
>
> h3. Environment
> Cordova: 6.5.0
> CordovaCommon: 2.0.0
> CordovaAndroid: 6.1.2
> h3. Description
> Using the edit-config in a plugin.xml to add an additional attribute on the
> manifest or application tag in AndroidManifest.xml does not work.
> h3. Steps to reproduce
> - Create new cordova project with android platform
> - (Copy initial AndroidManifest.xml for comparison)
> - Add cordova plugin which uses the edit-config setting to add a new
> attribute to manifest or application tag
> - Compare updated AndroidManifist.xml and see attribute was not added
> h3. Expectation
> Edit-config setting in plugin.xml allows to add/alter as well attributes on
> manifest/application/... level in AndroidManifest.xml
> ----
> h3. Example
> This will work
> {code:xml}
> <edit-config file="AndroidManifest.xml" target="/manifest/uses-sdk"
> mode="merge">
> <uses-sdk android:minSdkVersion="16" android:maxSdkVersion="23" />
> </edit-config>
> {code}
> This will *NOT* work
> {code:xml}
> <edit-file file="AndroidManifest.xml" target="/manifest" mode="merge">
> <manifest xmlns:tools="http://schemas.android.com/tools";></manifest>
> </edit-file>
> <edit-file file="AndroidManifest.xml" target="/manifest/application"
> mode="merge">
> <application tools:replace="android:icon"></application>
> </edit-file>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
