erisu edited a comment on pull request #823: URL: https://github.com/apache/cordova-ios/pull/823#issuecomment-630678261
@chriscant I want to confirm, What do you mean by > This incorrectly has > `PROVISIONING_PROFILE = profile name` > when it needs to have > `PROVISIONING_PROFILE_SPECIFIER = profile name` Because `PROVISIONING_PROFILE` is not the profile name. When configuring for manual signing in `build.json`, the `provisioningProfile` property contains the provisioning profile's `UUID` and not its name. If you are writing the name in this property, that is incorrect. When I read the changes from this PR, I feel that you might be changing what the `provisioningProfile` value is suppose to be, from what is documented. What I read from the changes is `PROVISIONING_PROFILE_SPECIFIER = UUID` when the `PROVISIONING_PROFILE_SPECIFIER` is the profile name. Here is the documentation on manual signing: https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#using-buildjson If you want to add `PROVISIONING_PROFILE_SPECIFIER` as an option, for supplying the name, a new `build.json` property should also be introduced to support this. Then in the code you can write conditional to set either `PROVISIONING_PROFILE_SPECIFIER`, `PROVISIONING_PROFILE`, or both if both is provided. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
