breautek opened a new pull request #978: URL: https://github.com/apache/cordova-android/pull/978
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixes: #698 ### Description <!-- Describe your changes in detail --> Changes `wait_for_boot` from using `ps` shell command to check for `android.process.acore` to `getprop sys.boot_completed` `android.process.acore` is a process that (despite it's name) is used for the `ContactsProvider`. The process is launched on boot, but will get killed after some amount of inactivity. When this happens, emulators that are opened for approximately 15 minutes or more will cause `cordova run android` to hang indefinitely. Using `getprop sys.boot_completed` is a more reliable way to determine if the simulator has been booted. A longer research comment I have posted on the issue ticket at https://github.com/apache/cordova-android/issues/698#issuecomment-632300908 Additionally one unit test has been updated to reflect this change. ### Testing <!-- Please describe in detail how you tested your changes. --> - Ran `npm test` - Tested android emulators between API 22 through R (API 30) to ensure that `getprop sys.boot_completed` indeed returns a value when expected to. - Ran `cordova run android` while the emulator was off to ensure emulator starts and installs the app properly. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
