erisu opened a new pull request #866:
URL: https://github.com/apache/cordova-ios/pull/866
### Motivation and Context
Use `file` as default scheme to avoid break in current apps/
### Description
1. defaults to `file` if preference `scheme` is not set.
2. continue to uses `file` if preference scheme is set to `file`.
3. use what ever value the user defines in as preference `scheme` as a
custom scheme handler, excluding `file` which was defined in the above case 2.
4. preference `hostname` is only used when `scheme` is not `file`.
5. `CDV_ASSETS_URL` is set to `<scheme>://<hostname>`
-> if `file`, `hostname = “”`.
-> if `!file`, `hostname = "localhost"` or user define value for
preference `hostname`.
6. Extension of above case 3, if `scheme` is set and is not `file`, it will
also validate against `WKWebView handlesURLScheme`, if it is not valid, it will
default to `app`
### Testing
- cordova build
- run in simulator
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
