NiklasMerz opened a new pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886


   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   This adds a prefrence to the webview which is useful for iPads. Apple 
introduced a setting which by defaults changes the useragent of iPads from 
`iPad` to `Macintosh` to provide a "desktop browsing experience". The new 
preference allows to change the default value.
   
   See original issue from IAB: apache/cordova-plugin-inappbrowser#687
   
   ### Description
   <!-- Describe your changes in detail -->
   Changed like : apache/cordova-plugin-inappbrowser#688
   
   Documenation: https://github.com/apache/cordova-docs/pull/1083
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Automatic tests still pass. I found no automatic tests for preferences at 
build time.
   
   I created a blank new app, added this platform and checked 
`navigator.userAgent` while changing the preference. It should be `iPad` for 
`mobile` and `Macintosh` for `desktop`.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to