timbru31 commented on a change in pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#discussion_r436663222
##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -393,11 +393,13 @@ module.exports.run = function () {
console.log('ANDROID_SDK_ROOT=' + process.env['ANDROID_SDK_ROOT'] + '
(recommended setting)');
console.log('ANDROID_HOME=' + process.env['ANDROID_HOME'] + '
(DEPRECATED)');
- if (!String(values[0]).startsWith('1.8.')) {
+ if (values[0] === undefined) {
Review comment:
Wouldn't this, theoretically, allow JDK <8, too? They would, e.g., start
with 1.6 for a JDK6. We should maybe use something like
[this](https://stackoverflow.com/a/1096159/1902598) in order to check for >= 52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
