[
https://issues.apache.org/jira/browse/CRAIL-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418093#comment-16418093
]
ASF GitHub Bot commented on CRAIL-19:
-------------------------------------
GitHub user PepperJo opened a pull request:
https://github.com/apache/incubator-crail/pull/13
Checkstyle plugin with google style
Add checkstyle plugin but do not check on compilation yet.
Checkstyle can be run with 'mvn checkstyle:check'
https://issues.apache.org/jira/projects/CRAIL/issues/CRAIL-19
Signed-off-by: Jonas Pfefferle <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PepperJo/incubator-crail codestyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-crail/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 436fcc384a053407c5f96862e0b192d3cd44093f
Author: Jonas Pfefferle <pepperjo@...>
Date: 2018-03-28T20:54:19Z
Checkstyle plugin with google style
Add checkstyle plugin but do not check on compilation yet.
Checkstyle can be run with 'mvn checkstyle:check'
https://issues.apache.org/jira/projects/CRAIL/issues/CRAIL-19
Signed-off-by: Jonas Pfefferle <[email protected]>
----
> Check code style on build
> -------------------------
>
> Key: CRAIL-19
> URL: https://issues.apache.org/jira/browse/CRAIL-19
> Project: Apache Crail
> Issue Type: Improvement
> Reporter: Jonas Pfefferle
> Priority: Major
>
> Style check the code on compile and fail compilation if there are violations.
> I propose using the google java code style guide, which is already pretty
> close to what we are having now (e.g. does not allow no braces on if/else
> etc). Spark also uses a modified version of the google code style.
> [https://google.github.io/styleguide/javaguide.html]
> [https://github.com/apache/spark/blob/master/dev/checkstyle.xml]
> Supported by many formatters, IDEs, etc like Intellij, clang-format, Eclipse:
> https://github.com/google/styleguide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
