[ 
https://issues.apache.org/jira/browse/CXF-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611374#action_12611374
 ] 

Glen Mazza commented on CXF-1692:
---------------------------------

I disagree with the principle of this--extraargs should be equivalent to those 
command-line parameters of the wsdl2java tool, 1-to-1 with ideally zero 
difference.  That's what provides the easiest and fastest upgrading and 
downgrading between command-line and Maven, and between Maven and the raw Ant 
<java/> task. [1]

Yes, the params above are prettier, but now we need to document their names 
(and keep maintaining them as we add more settings in), and now those 
graduating from command-line to Maven usage (or needing to downgrade quickly to 
command line for debugging purposes) have to keep doing annoying dictionary 
lookups to map between the two.  We made that mistake in the past with our 
pretty-name Ant tasks[2], meant as a replacement for the uglier (relying on 
command-line options) raw Ant <java/> task--the pretty-name Ant tasks have 
fallen behind and nobody's been maintaining them.

However, I would have less problem with this change if we can still rely on 
extraargs in addition to these new prettier terms, and also, if the Ant task 
used the same parameter names as the ones you're proposing above (i.e., keep 
the pretty names consistent between the Ant task and the what you're proposing 
above--either changing the Ant task values or those of your Maven ones above 
for consistency.)

Thanks,
Glen

[1] http://cwiki.apache.org/CXF20DOC/wsdl-to-java.html#WSDLtoJava-usingant
[2] http://cwiki.apache.org/CXF20DOC/ant-tasks.html


> cfx-codegen-plugin: Should be possible to configure using named parameters.
> ---------------------------------------------------------------------------
>
>                 Key: CXF-1692
>                 URL: https://issues.apache.org/jira/browse/CXF-1692
>             Project: CXF
>          Issue Type: Improvement
>          Components: Tooling
>    Affects Versions: 2.1.1
>            Reporter: Dave Leatherdale
>         Attachments: 1692.diff
>
>
> It should not be necessary to use extraargs to configure parameters named 
> parameter should be used instead. Extraargs should remain for unusual 
> circumstances and backwards compatibility.
> The options are configured as follows:
>                                       <defaultOptions>
>                                               <packagenames>
>                                                       
> <packagename>packagename</packagename>
>                                               </packagenames>
>                                               
> <defaultExcludesNamespace>true</defaultExcludesNamespace>
>                                               
> <defaultNamespacePackageMapping>true</defaultNamespacePackageMapping>
>                                               <wsdlLocation></wsdlLocation>
>                                               <frontEnd>jaxws</frontEnd>
>                                               <dataBinding>jaxb</dataBinding>
>                                               <wsdlVersion>1.1</wsdlVersion>
>                                               <catalog>catalog</catalog>
>                                               
> <extendedSoapHeaders>true</extendedSoapHeaders>
>                                               
> <validateWsdl>true</validateWsdl>
>                                               
> <serviceName>serviceName</serviceName>
>                                               
> <autoNameResolution>true</autoNameResolution>
>                                               
> <noAddressBinding>true</noAddressBinding>
>                                       </defaultOptions>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to